[CMcC] 20050227:  The process of uploading a file to a server entails encoding the file (and other form elements) as multipart/form-data.  The code below handles that.

The second part of the upload will use [http] to send a -query with -type multipart/form-data, causing the client to POST the mime multipart/form-data to the server.  Voila.

Note: Has anyone been able to upload a file with this anywhere? Not only that it does not read the file in binary mode (which causes data corruption).. also the returned data does contain headerlines that do not get put in the actual http header, if you simply pass the returned block to the -query parameter of http::geturl .. which causes a wrong content-type and then everything goes down the drain.. also, but thats the smallest issue, most places like it when you pass a filename aswell - but that could just be added to the disposition of add_binary as 'filename="somename.jpg"'..

Note II: I did some changes to bring the script a little closer to a state, where its actually working, but its still not fully doing what it should because of the "header-problem"..

-----

[BR] 2005-06-02 - I also tried to make it work.  I wanted to test a Java upload servlet which was based on Jakarta's common-fileupload.

Problems (I'll get formal bug reports rolling later):

   * The mime package doesn't have a getheaders method and getbody doesn't work for multipart.  I think buildmessage should be split into those two functions.  That is the "headers-problem" mentioned above.

   * The mime package appends a spurious additional \r\n to each item in the multipart data.  That is because mime appends a \r\n to each item and than ''also'' adds a \r\n before the boundary.

   * commons-fileupload doesn't understand the quoted boundary spec correctly which the mime package produces in the Content-Type header.  This is a bug in commons-fileupload, I guess, but maybe the mime package should not make things complicated here.

   * The http package can't source POST data from memory, it wants a channel (or alternatively, the mime package can't produce a channel for use with http).

All those problems can be worked around but the amount of code is so much that it seems easier to just roll my own for now.

-----

 # Provide multipart/form-data for http
 
 package provide form-data 1.0
 package require mime
 
 namespace eval form-data {}
 
 proc form-data::compose {partv {type multipart/form-data}} {
     upvar 1 $partv parts
 
     set mime [mime::initialize -canonical $type -parts $parts]
     set packaged [mime::buildmessage $mime]
     foreach part $parts {
 	mime::finalize $part
     }
     mime::finalize $mime
 
     return $packaged
 }
 
 proc form-data::add_binary {partv name filename value type} {
     upvar 1 $partv parts
     set disposition "form-data; name=\"${name}\"; filename=\"$filename\""
     lappend parts [mime::initialize -canonical $type \
 		   -string $value \
 		   -encoding binary \
 		   -header [list Content-Disposition $disposition]]
 }
 
 proc form-data::add_field {partv name value} {
     upvar 1 $partv parts
     set disposition "form-data; name=\"${name}\""
     lappend parts [mime::initialize -canonical text/plain -string $value \
 		       -header [list Content-Disposition $disposition]]
 }
 
 proc form-data::format {name filename value type args} {
     set parts {}
     foreach {n v} $args {
 	add_field parts $n $v
     }
     add_binary parts $name $filename $value $type
     return [compose parts]
 }
 
 if {[info script] eq $argv0} {
 
     # format a gif file upload according to the following form:
     #<FORM METHOD="POST" ENCTYPE="multipart/form-data" ACTION="upload.php"> 
     #<INPUT TYPE="HIDDEN" NAME="MAX_FILE_SIZE" VALUE=" "> 
     #<INPUT TYPE="HIDDEN" NAME="action" VALUE="1"> 
     #<INPUT TYPE="FILE" NAME="file1">
     #<INPUT TYPE="SUBMIT" VALUE="Host It"> <br> 
     #<INPUT TYPE="text" NAME="img_resize"  SIZE="4" MAXLENGTH="4">
     #</FORM>
 
     # get contents of the gif
     set fd [open ./logo125.gif]
     fconfigure $fd -translation binary
     set image [read $fd]
     close $fd
 
     # set up other fields
     array set fields {
 	MAX_FILE_SIZE " "
 	action 1
 	img_resize "100%"
     }
 
     # format the image and form
     puts [form-data::format file1 "logo125.gif" $image image/gif {expand}[array get fields]]
 }

[BR] 2005-06-02 - This proc works around the "header-problem" and it uses a temporary file for the body data to connect to the http package.

 package require http
 
 proc form-data::post {url field type file {params {}} {headers {}}} {
     # get contents of the file
     set fd [open $file r]
     fconfigure $fd -translation binary
     set content [read $fd]
     close $fd
 
     # format the image and form
     set message [eval [list form-data::format \
                                $field [file tail $file] $content $type] \
                          $params]
 
     # parse the headers out of the message body
     set message [split [string map {"\r\n\r\n" "\1"} $message] "\1"]
     set headers_raw [lindex $message 0]
     set body [join [lrange $message 1 end] "\r\n\r\n"]
 
     set headers_raw [string map {"\r\n " " " "\r\n" "\n"} $headers_raw]
     regsub {  +} $headers_raw " " headers_raw
     #set headers {} -- initial value comes from parameter
     foreach line [split $headers_raw "\n"] {
         regexp {^([^:]+): (.*)$} $line all label value
         lappend headers $label $value
     }
 
     # get the content-type
     array set ha $headers
     set content_type $ha(Content-Type)
     unset ha(Content-Type)
     set headers [array get ha]
 
     # create a temporary file for the body data (getting the temp directory
     # is more involved if you want to support Windows right)
     set datafile "/tmp/post[pid]"
     set data [open $datafile w+]
     fconfigure $data -translation binary
     puts -nonewline $data $body
     seek $data 0
 
     # POST it
     set token [http::geturl $url -type $content_type -binary true \
                        -headers $headers -querychannel $data]
     http::wait $token
 
     # cleanup the temporary
     close $data
     file delete $datafile
 
     return $token
 }